Take a few seconds to open Dialog Box in Windows Form Application

Phillip Stewart 0

I have a C# project, which is a Windows Form application.

When clicking a button and opening dialog box, it takes a few seconds to open.

How can I improve this?

If needed, you can help me by having remote access to my PC.

P a u l 10,731 Reputation points

2024-08-30T21:32:16.62+00:00

This could be for numerous reasons. Could you show a few extracts from the Form that you're calling ShowDialog() on? Specifically the constructor & Form_Load callback.
Phillip Stewart 0 Reputation points

2024-08-31T01:58:20.6333333+00:00

Yes, I will show you. I will give you remote access to my PC.
RLWA32 45,396 Reputation points

2024-08-31T08:40:45.05+00:00

@Phillip Stewart, If you post the information requested by @P a u l then any community member that wants to assist you can respond to your question. Remote access to your system is not necessary.
Phillip Stewart 0 Reputation points

2024-09-01T20:31:22.16+00:00

This is a callback to open Dialog.
private void btnOpenCloud_Click(object sender, EventArgs e)

{

using (SaveGraphDialog saveGraphDialog = new SaveGraphDialog())

{

saveGraphDialog.hideButtons();

try

{

saveGraphDialog.ShowDialog(this);

}

catch

{

Console.WriteLine("Error in opening SaveGraphDialog");

}

}

}

This is constructor.

public SaveGraphDialog()

{

InitializeComponent();

// Initialize the BindingList

folderInfos = new BindingList<FolderInfo>();

// Populate TreeView

PopulateTreeView();

parentFolderID = Guid.Empty;

previouseParentFolderID = Guid.Empty;

previousClientWidth = this.ClientSize.Width; // Initialize previous width

previousClientHeight = this.ClientSize.Height; // Initialize previous height

this.MinimumSize = new Size(900, 480);

}

This is a PopulateTreeView funciton.

private async void PopulateTreeView()

{

List<Enterprise> userEnterprises = await AuthAPI.GetUserEnterprises(AuthAPI._user_guid);

foreach(Enterprise userEnterprise in userEnterprises)

{

TreeNode rootNode = new TreeNode(userEnterprise.Name);

rootNode.Tag = userEnterprise;

AddTenantsForEnterprise(rootNode, userEnterprise.GUID);

treeView1.Nodes.Add(rootNode);

}

}

1 answer

Jiale Xue - MSFT 44,926 Reputation points Microsoft Vendor

2024-09-02T10:00:28.79+00:00
Hi @Phillip Stewart , Welcome to Microsoft Q&A,

The delay in opening the SaveGraphDialog may be due to the PopulateTreeView method, which is asynchronous and may take some time to complete, especially when the AuthAPI.GetUserEnterprises call involves network communication or other time-consuming operations.

Show the Dialog First: You can show the dialog first and then populate the TreeView in the background. This approach will allow the dialog to appear immediately, and the tree will be populated afterward.

public SaveGraphDialog() { InitializeComponent(); folderInfos = new BindingList<FolderInfo>(); parentFolderID = Guid.Empty; previouseParentFolderID = Guid.Empty; previousClientWidth = this.ClientSize.Width; previousClientHeight = this.ClientSize.Height; this.MinimumSize = new Size(900, 480); // Show the dialog and then populate the tree view this.Shown += async (sender, e) => await PopulateTreeViewAsync(); } private async Task PopulateTreeViewAsync() { List<Enterprise> userEnterprises = await AuthAPI.GetUserEnterprises(AuthAPI._user_guid); foreach (Enterprise userEnterprise in userEnterprises) { TreeNode rootNode = new TreeNode(userEnterprise.Name); rootNode.Tag = userEnterprise; AddTenantsForEnterprise(rootNode, userEnterprise.GUID); treeView1.Nodes.Add(rootNode); } }

If possible, preload the data before opening the dialog. This way, when the dialog opens, it can display the preloaded data immediately.

Consider loading only the top-level nodes initially and then load child nodes as the user expands each node.

Best Regards,

Jiale

If the answer is the right solution, please click "Accept Answer" and kindly upvote it. If you have extra questions about this answer, please click "Comment".

Note: Please follow the steps in our documentation to enable e-mail notifications if you want to receive the related email notification for this thread.
Please sign in to rate this answer.
Phillip Stewart 0 Reputation points

2024-09-02T12:51:31.2133333+00:00

@Jiale Xue - MSFT . Thank you for your answer.I did what you said. But no change.

I commented all codes in SaveGraphDialog constructor, except for InitializeComponent, and still taking some time to open dialog.

It seems that InitializeComponent takes some time.

Jiale Xue - MSFT 44,926 Reputation points Microsoft Vendor

2024-09-03T02:04:30.97+00:00

The problem may be related to the complexity or size of the components initialized in the dialog box, or it may be a resource-intensive control such as a data-bound control or a large image

If possible, break down the "InitializeComponent" method to determine which specific controls or actions are causing the delay. You can isolate the problem by temporarily commenting out parts of the code generated in "InitializeComponent". Consider deferring the loading or initialization of some components until after the dialog box is shown. For example, you can move part of the initialization logic to the "Shown" event of the dialog box instead of initializing all controls in "InitializeComponent". If the form contains complex controls such as TreeView, DataGrid with many columns, or custom-drawn controls, consider simplifying them or initializing them with fewer items and adding more items later. If you are using a control that displays a lot of data, consider using virtualization techniques to load only the visible portion of the data and load other data as needed. In short, it is normal for InitializeComponent to take some time.
Sign in to comment

Use comments to ask for clarification, additional information, or improvements to the question.

Share via

Take a few seconds to open Dialog Box in Windows Form Application

1 answer

Your answer